lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1505590431.16316.9.camel@perches.com> Date: Sat, 16 Sep 2017 12:33:51 -0700 From: Joe Perches <joe@...ches.com> To: Colin King <colin.king@...onical.com>, Wolfram Sang <wsa@...-dreams.de>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...com>, linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] i2c: i2c-stm32f7: make structure stm32f7_setup static On Sat, 2017-09-16 at 12:33 +0100, Colin King wrote: > From: Colin Ian King <colin.king@...onical.com> > > The structure stm32f7_setup is local to the source and does not need > to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'stm32f7_setup' was not declared. Should it be static? [] > diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c [] > @@ -265,7 +265,7 @@ static struct stm32f7_i2c_spec i2c_specs[] = { > }, > }; > > -struct stm32f7_i2c_setup stm32f7_setup = { > +static struct stm32f7_i2c_setup stm32f7_setup = { better to use static const > .rise_time = STM32F7_I2C_RISE_TIME_DEFAULT, > .fall_time = STM32F7_I2C_FALL_TIME_DEFAULT, > .dnf = STM32F7_I2C_DNF_DEFAULT,
Powered by blists - more mailing lists