lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Sep 2017 23:23:45 -0700 From: Dmitriy Cherkasov <dmitriy@...-tech.org> To: Daniel Lezcano <daniel.lezcano@...aro.org>, Palmer Dabbelt <palmer@...belt.com>, peterz@...radead.org, tglx@...utronix.de, jason@...edaemon.net, marc.zyngier@....com, Arnd Bergmann <arnd@...db.de> Cc: yamada.masahiro@...ionext.com, mmarek@...e.com, albert@...ive.com, will.deacon@....com, boqun.feng@...il.com, oleg@...hat.com, mingo@...hat.com, gregkh@...uxfoundation.org, jslaby@...e.com, davem@...emloft.net, mchehab@...nel.org, hverkuil@...all.nl, rdunlap@...radead.org, viro@...iv.linux.org.uk, mhiramat@...nel.org, fweisbec@...il.com, mcgrof@...nel.org, dledford@...hat.com, bart.vanassche@...disk.com, sstabellini@...nel.org, mpe@...erman.id.au, rmk+kernel@...linux.org.uk, paul.gortmaker@...driver.com, nicolas.dichtel@...nd.com, linux@...ck-us.net, heiko.carstens@...ibm.com, schwidefsky@...ibm.com, geert@...ux-m68k.org, akpm@...ux-foundation.org, andriy.shevchenko@...ux.intel.com, jiri@...lanox.com, vgupta@...opsys.com, airlied@...hat.com, jk@...abs.org, chris@...is-wilson.co.uk, Jason@...c4.com, paulmck@...ux.vnet.ibm.com, ncardwell@...gle.com, linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org, patches@...ups.riscv.org Subject: Re: [PATCH v8 10/18] RISC-V: Init and Halt Code On 09/13/2017 11:15 AM, Daniel Lezcano wrote: > > All this code must go in the timer side and use the TIMER_OF_DECLARE > macro with the proper wrappers. Hi, thanks for the feedback. Agreed. I'll clean this up. > > Where is the request_per_cpu_interrupt()? > > What is this riscv_timer_interrupt() signature? This arch defines a separate exception type for local timer interrupts. Currently the interrupt controller driver checks the trap cause register, determines that it's a timer, and calls the handler directly. To make this go through the interrupt subsystem, this driver would need to be reworked. > > Where is get_cycles64() ? This is in asm/timex.h. Should this be split into a separate asm header ala arm64? > > The timer driver should be self-contained and not spread across > different places, it is very difficult to review it. > > [ ... ] > Agreed, thanks again for reviewing it anyway :)
Powered by blists - more mailing lists