lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 15 Sep 2017 23:23:45 -0700
From:   Dmitriy Cherkasov <>
To:     Daniel Lezcano <>,
        Palmer Dabbelt <>,,,,,
        Arnd Bergmann <>
Subject: Re: [PATCH v8 10/18] RISC-V: Init and Halt Code

On 09/13/2017 11:15 AM, Daniel Lezcano wrote:
> All this code must go in the timer side and use the TIMER_OF_DECLARE
> macro with the proper wrappers.

Hi, thanks for the feedback.

Agreed. I'll clean this up.

> Where is the request_per_cpu_interrupt()?
> What is this riscv_timer_interrupt() signature?

This arch defines a separate exception type for local timer interrupts. 
Currently the interrupt controller driver checks the trap cause register, 
determines that it's a timer, and calls the handler directly. To make this go 
through the interrupt subsystem, this driver would need to be reworked.

> Where is get_cycles64() ?

This is in asm/timex.h. Should this be split into a separate asm header ala arm64?

> The timer driver should be self-contained and not spread across
> different places, it is very difficult to review it.
> [ ... ]

Agreed, thanks again for reviewing it anyway :)

Powered by blists - more mailing lists