lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 16 Sep 2017 14:53:39 +0400 From: Anton Sviridenko <anton@...p.bluecherry.net> To: Arnd Bergmann <arnd@...db.de> Cc: Bluecherry Maintainers <maintainers@...echerrydvr.com>, Ismael Luceno <ismael@...ev.co.uk>, Andrey Utkin <andrey.utkin@...p.bluecherry.net>, Mauro Carvalho Chehab <mchehab@...nel.org>, Hans Verkuil <hans.verkuil@...co.com>, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] [media] solo6x10: hide unused variable On Fri, Sep 15, 2017 at 09:52:04PM +0200, Arnd Bergmann wrote: > When building without CONFIG_GPIOLIB, we get a harmless > warning about an unused variable: > > drivers/media/pci/solo6x10/solo6x10-gpio.c: In function 'solo_gpio_init': > drivers/media/pci/solo6x10/solo6x10-gpio.c:165:6: error: unused variable 'ret' [-Werror=unused-variable] > > This adds another #ifdef around the declaration. > > Fixes: d3202d1981dc ("media: solo6x10: export hardware GPIO pins 8:31 to gpiolib interface") > Signed-off-by: Arnd Bergmann <arnd@...db.de> > --- > drivers/media/pci/solo6x10/solo6x10-gpio.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/pci/solo6x10/solo6x10-gpio.c b/drivers/media/pci/solo6x10/solo6x10-gpio.c > index 3d0d1aa2f6a8..7b4641a2cb84 100644 > --- a/drivers/media/pci/solo6x10/solo6x10-gpio.c > +++ b/drivers/media/pci/solo6x10/solo6x10-gpio.c > @@ -162,7 +162,9 @@ static void solo_gpiochip_set(struct gpio_chip *chip, > > int solo_gpio_init(struct solo_dev *solo_dev) > { > +#ifdef CONFIG_GPIOLIB > int ret; > +#endif > > solo_gpio_config(solo_dev); > #ifdef CONFIG_GPIOLIB > -- > 2.9.0 > Acked-by: Anton Sviridenko <anton@...p.bluecherry.net>
Powered by blists - more mailing lists