lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1505673094.16316.10.camel@perches.com> Date: Sun, 17 Sep 2017 11:31:34 -0700 From: Joe Perches <joe@...ches.com> To: Masahiro Yamada <yamada.masahiro@...ionext.com>, Andrew Morton <akpm@...ux-foundation.org> Cc: Ingo Molnar <mingo@...nel.org>, Sergey Senozhatsky <sergey.senozhatsky@...il.com>, Steven Rostedt <rostedt@...dmis.org>, Petr Mladek <pmladek@...e.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] printk: simplify no_printk() On Mon, 2017-09-18 at 00:01 +0900, Masahiro Yamada wrote: > Commit 069f0cd00df0 ("printk: Make the printk*once() variants return > a value") surrounded the macro implementation with ({ ... }). > > Now, the inner do { ... } while (0); is redundant. thanks. > diff --git a/include/linux/printk.h b/include/linux/printk.h [] > @@ -131,10 +131,8 @@ struct va_format { > */ > #define no_printk(fmt, ...) \ > ({ \ > - do { \ > - if (0) \ > - printk(fmt, ##__VA_ARGS__); \ > - } while (0); \ > + if (0) \ > + printk(fmt, ##__VA_ARGS__); \ > 0; \ > })
Powered by blists - more mailing lists