linux-kernel - Re: [PATCH] checkpatch: do not check missing blank line before builtin_*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1505681081.16316.13.camel@perches.com>
Date:   Sun, 17 Sep 2017 13:44:41 -0700
From:   Joe Perches <joe@...ches.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Andy Whitcroft <apw@...onical.com>
Cc:     Paul Gortmaker <paul.gortmaker@...driver.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: do not check missing blank line before
 builtin_*_driver

On Sun, 2017-09-17 at 23:59 +0900, Masahiro Yamada wrote:
> checkpatch.pl does not check missing blank line before module_*_driver.
> I want it to behave likewise for builtin_*_driver.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index dd2c262aebbf..cec896306619 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3103,6 +3103,7 @@ sub process {
>  		      $line =~ /^\+[a-z_]*init/ ||
>  		      $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ ||
>  		      $line =~ /^\+\s*DECLARE/ ||
> +		      $line =~ /^\+\s*builtin_/ ||

I believe

		      $line =~ /^\+\s*builtin_[\w_]*driver/ ||

would be better