linux-kernel - Re: [PATCH] cifs: hide unused functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH2r5mvtUBU9VY0yA32nj5jubgTxxygqQNScjH=w3e6Gz21GmQ@mail.gmail.com>
Date:   Sun, 17 Sep 2017 17:03:10 -0500
From:   Steve French <smfrench@...il.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Arnd Bergmann <arnd@...db.de>, Steve French <sfrench@...ba.org>,
        Pavel Shilovsky <pshilov@...rosoft.com>,
        Sachin Prabhu <sprabhu@...hat.com>,
        Aurelien Aptel <aaptel@...e.com>,
        Ronnie Sahlberg <lsahlber@...hat.com>,
        "linux-cifs@...r.kernel.org" <linux-cifs@...r.kernel.org>,
        samba-technical <samba-technical@...ts.samba.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cifs: hide unused functions

merged into cifs-2.6.git for-next

On Sun, Sep 10, 2017 at 5:28 AM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
> On Tue, Sep 5, 2017 at 11:24 AM, Arnd Bergmann <arnd@...db.de> wrote:
>> The newly added SMB2+ attribute support causes unused function
>> warnings when CONFIG_CIFS_XATTR is disabled:
>>
>> fs/cifs/smb2ops.c:563:1: error: 'smb2_set_ea' defined but not used [-Werror=unused-function]
>>  smb2_set_ea(const unsigned int xid, struct cifs_tcon *tcon,
>> fs/cifs/smb2ops.c:513:1: error: 'smb2_query_eas' defined but not used [-Werror=unused-function]
>>  smb2_query_eas(const unsigned int xid, struct cifs_tcon *tcon,
>>
>> This adds another #ifdef around the affected functions.
>>
>> Fixes: 5517554e4313 ("cifs: Add support for writing attributes on SMB2+")
>> Fixes: 95907fea4fd8 ("cifs: Add support for reading attributes on SMB2+")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Thanks,

Steve