linux-kernel - Re: [PATCH] media: imx: Fix VDIC CSI1 selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 18 Sep 2017 16:07:28 -0700
From:   Steve Longerbeam <slongerbeam@...il.com>
To:     Tim Harvey <tharvey@...eworks.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: imx: Fix VDIC CSI1 selection

Thanks Tim for catching this error.

Acked-by: Steve Longerbeam <steve_longerbeam@...tor.com>


On 09/18/2017 04:08 PM, Tim Harvey wrote:
> When using VDIC with CSI1, make sure to select the correct CSI in
> IPU_CONF.
>
> Fixes: f0d9c8924e2c3376 ("[media] media: imx: Add IC subdev drivers")
> Suggested-by: Marek Vasut <marex@...x.de>
> Signed-off-by: Tim Harvey <tharvey@...eworks.com>
> ---
>   drivers/staging/media/imx/imx-ic-prp.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-ic-prp.c b/drivers/staging/media/imx/imx-ic-prp.c
> index c2bb5ef..9e41987 100644
> --- a/drivers/staging/media/imx/imx-ic-prp.c
> +++ b/drivers/staging/media/imx/imx-ic-prp.c
> @@ -320,9 +320,10 @@ static int prp_link_validate(struct v4l2_subdev *sd,
>   		 * the ->PRPENC link cannot be enabled if the source
>   		 * is the VDIC
>   		 */
> -		if (priv->sink_sd_prpenc)
> +		if (priv->sink_sd_prpenc) {
>   			ret = -EINVAL;
> -		goto out;
> +			goto out;
> +		}
>   	} else {
>   		/* the source is a CSI */
>   		if (!csi) {