linux-kernel - Re: [PATCH net] net: phy: Fix mask value write on gmii2rgmii converter speed register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170918.163408.207952584990169576.davem@davemloft.net>
Date:   Mon, 18 Sep 2017 16:34:08 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fahad.kunnathadi@...celdesigns.com
Cc:     f.fainelli@...il.com, michal.simek@...inx.com, andrew@...n.ch,
        appanad@...inx.com, soren.brinkmann@...inx.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: phy: Fix mask value write on gmii2rgmii
 converter speed register

From: Fahad Kunnathadi <fahad.kunnathadi@...celdesigns.com>
Date: Fri, 15 Sep 2017 12:01:58 +0530

> To clear Speed Selection in MDIO control register(0x10),
> ie, clear bits 6 and 13 to zero while keeping other bits same.
> Before AND operation,The Mask value has to be perform with bitwise NOT
> operation (ie, ~ operator)
> 
> This patch clears current speed selection before writing the
> new speed settings to gmii2rgmii converter
> 
> Fixes: f411a6160bd4 ("net: phy: Add gmiitorgmii converter support")
> 
> Signed-off-by: Fahad Kunnathadi <fahad.kunnathadi@...celdesigns.com>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

Applied and queued up for -stable, thanks.