lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 18 Sep 2017 16:51:10 -0700
From:   Christoph Hellwig <>
To:     Jianchao Wang <>
Cc:     Jens Axboe <>,,
Subject: Re: [PATCH] block: move sanity checking ahead of
 bi_front/back_seg_size updating

On Sat, Sep 16, 2017 at 07:10:30AM +0800, Jianchao Wang wrote:
> If the bio_integrity_merge_rq() return false or nr_phys_segments exceeds
> the max_segments, the merging fails, but the bi_front/back_seg_size may
> have been modified. To avoid it, move the sanity checking ahead.
> Signed-off-by: Jianchao Wang <>

This looks fine to me:

Reviewed-by: Christoph Hellwig <>

But can you elaborate a little more on how this found and if there
is a way to easily reproduce it, say for a blktests test case?

Powered by blists - more mailing lists