linux-kernel - Re: [PATCH] Revert "KVM: Don't accept obviously wrong gsi values via KVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <871sn4jyjz.fsf@concordia.ellerman.id.au>
Date:   Mon, 18 Sep 2017 16:44:32 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Jan H. Schönherr <jschoenh@...zon.de>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>
Cc:     sachinp@...ux.vnet.ibm.com, kvm@...r.kernel.org,
        Jan H. Schönherr 
        <jschoenh@...zon.de>, linux-kernel@...r.kernel.org,
        Abdul Haleem <abdhalee@...ux.vnet.ibm.com>,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] Revert "KVM: Don't accept obviously wrong gsi values via KVM_IRQFD"

"Jan H. Schönherr" <jschoenh@...zon.de> writes:

> This reverts commit 36ae3c0a36b7456432fedce38ae2f7bd3e01a563.
>
> The commit broke compilation on !CONFIG_HAVE_KVM_IRQ_ROUTING. Also,
> there may be cases with CONFIG_HAVE_KVM_IRQ_ROUTING, where larger
> gsi values make sense.
>
> As the commit was meant as an early indicator to user space that
> something is wrong, reverting just restores the previous behavior
> where overly large values are ignored when encountered (without
> any direct feedback).
>
> Reported-by: Abdul Haleem <abdhalee@...ux.vnet.ibm.com>
> Signed-off-by: Jan H. Schönherr <jschoenh@...zon.de>
> ---
>  virt/kvm/eventfd.c | 2 --
>  1 file changed, 2 deletions(-)

Can someone merge this or preferably just send it straight to Linus, the
original patch has broken the powerpc build in mainline.

cheers