linux-kernel - Re: [PATCH] perf, tools: Fix adding multiple event groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Sep 2017 08:58:45 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Andi Kleen <andi@...stfloor.org>
Cc:     acme@...nel.org, jolsa@...nel.org, linux-kernel@...r.kernel.org,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] perf, tools: Fix adding multiple event groups

On Thu, Sep 14, 2017 at 01:57:35PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@...ux.intel.com>
> 
> The -M metric group parser threw away the events of earlier
> groups when multiple groups were specified. Fix this here
> by not overwriting the string incorrectly.
> 
> Now this works correctly:
> 
> % perf stat -M Summary,SMT --metric-only -a sleep 1
> 
>  Performance counter stats for 'system wide':
> 
> Instructions         CPI                  CLKS                 CPU_Utilization      GFLOPs               SMT_2T_Utilization   SMT_2T_Utilization   Kernel_Utilization   CoreIPC              CORE_CLKS
> 900907376.0              2.7            2398954144.0             0.1                 0.0                 0.2                 0.2                 0.1                 0.4            2080822855.5
> 
> while previously it would only show the SMT metrics.
> 
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka