linux-kernel - Re: [PATCH] lightnvm: remove already calculated nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <C22FF934-D7A2-4B1F-8172-011E596A5EE8@lightnvm.io>
Date:   Mon, 18 Sep 2017 09:56:06 +0200
From:   Javier González <jg@...htnvm.io>
To:     Rakesh Pandit <rakesh@...era.com>
Cc:     Matias Bjørling <mb@...htnvm.io>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lightnvm: remove already calculated nr_chnls

> On 17 Sep 2017, at 23.04, Rakesh Pandit <rakesh@...era.com> wrote:
> 
> Remove repeated calculation for number of channels while creating a
> target device.
> 
> Signed-off-by: Rakesh Pandit <rakesh@...era.com>
> ---
> 
> This is also a trivial change I found while investigating/working on
> other issue.
> 
> drivers/lightnvm/core.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
> index 1b8338d..01536b8 100644
> --- a/drivers/lightnvm/core.c
> +++ b/drivers/lightnvm/core.c
> @@ -139,7 +139,6 @@ static struct nvm_tgt_dev *nvm_create_tgt_dev(struct nvm_dev *dev,
> 	int prev_nr_luns;
> 	int i, j;
> 
> -	nr_chnls = nr_luns / dev->geo.luns_per_chnl;
> 	nr_chnls = (nr_chnls_mod == 0) ? nr_chnls : nr_chnls + 1;
> 
> 	dev_map = kmalloc(sizeof(struct nvm_dev_map), GFP_KERNEL);
> --
> 2.7.4

We wanted to make sure that nr_chnls was really, really set :)

Reviewed-by: Javier González <javier@...xlabs.com>


Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)