linux-kernel - Re: [PATCH] kbuild: rpm-pkg: delete firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Sep 2017 11:24:12 +0200
From:   Greg K-H <gregkh@...uxfoundation.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     linux-kbuild@...r.kernel.org,
        Markus Trippelsdorf <markus@...ppelsdorf.de>,
        Michal Marek <mmarek@...e.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: rpm-pkg: delete firmware_install to fix build
 error

On Mon, Sep 18, 2017 at 06:12:36PM +0900, Masahiro Yamada wrote:
> Commit 5620a0d1aacd ("firmware: delete in-kernel firmware") deleted
> in-kernel firmware support, including "make firmware_install".
> 
> Since then, "make rpm-pkg" / "make binrpm-pkg" fails to build with
> the error:
> 
>   make[2]: *** No rule to make target `firmware_install'.  Stop.
> 
> Commit df85b2d767aa ("firmware: Restore support for built-in firmware")
> restored the build infrastructure for CONFIG_EXTRA_FIRMWARE, but this
> is out of the scope of "make firmware_install".  So, the right thing to
> do is to kill the use of "make firmware_install".
> 
> Fixes: 5620a0d1aacd ("firmware: delete in-kernel firmware")
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
>  scripts/package/mkspec | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)

Nice find, what's the odds the debian package "script" also needs this
fix?

thanks,

greg k-h