lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Sep 2017 17:25:28 +0800 From: "Yang, Wenyou" <Wenyou.Yang@...rochip.com> To: Sakari Ailus <sakari.ailus@....fi> CC: Jonathan Corbet <corbet@....net>, Nicolas Ferre <nicolas.ferre@...rochip.com>, <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, Linux Media Mailing List <linux-media@...r.kernel.org>, Mauro Carvalho Chehab <mchehab@...pensource.com> Subject: Re: [PATCH v4 2/3] media: ov7670: Add the get_fmt callback Hi Sakari, On 2017/9/18 15:36, Sakari Ailus wrote: > Hi Wenyou, > > On Mon, Sep 18, 2017 at 02:45:13PM +0800, Wenyou Yang wrote: >> @@ -998,8 +1002,15 @@ static int ov7670_set_fmt(struct v4l2_subdev *sd, >> ret = ov7670_try_fmt_internal(sd, &format->format, NULL, NULL); >> if (ret) >> return ret; >> - cfg->try_fmt = format->format; >> +#ifdef CONFIG_VIDEO_V4L2_SUBDEV_API >> + struct v4l2_mbus_framefmt *mbus_fmt; > This will emit a compiler warning at least. Thank you for your review. Will be fixed in next version. > >> + >> + mbus_fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad); >> + *mbus_fmt = format->format; >> return 0; >> +#else >> + return -ENOTTY; >> +#endif >> } >> >> ret = ov7670_try_fmt_internal(sd, &format->format, &ovfmt, &wsize); Best Regards, Wenyou Yang
Powered by blists - more mailing lists