lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Sep 2017 13:50:16 +0300 From: Sakari Ailus <sakari.ailus@...ux.intel.com> To: john.hubbard@...il.com Cc: LKML <linux-kernel@...r.kernel.org>, Rob Herring <robh@...nel.org>, Mika Westerberg <mika.westerberg@...ux.intel.com>, "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>, John Hubbard <jhubbard@...dia.com> Subject: Re: [PATCH 1/1] acpi: unbreak ACPI_HANDLE(), encapsulate fwnode_operations Hi John, On Fri, Sep 15, 2017 at 05:35:27PM -0700, john.hubbard@...il.com wrote: > From: John Hubbard <jhubbard@...dia.com> > > Due to commit db3e50f3234b ("device property: Get rid of struct > fwnode_handle type field"), ACPI_HANDLE() inadvertently became > a GPL-only call. The call path that led to that was: > > ACPI_HANDLE() > ACPI_COMPANION() > to_acpi_device_node() > is_acpi_device_node() > acpi_device_fwnode_ops > DECLARE_ACPI_FWNODE_OPS(acpi_device_fwnode_ops); > > ...and the new DECLARE_ACPI_FWNODE_OPS() includes > EXPORT_SYMBOL_GPL, whereas previously it was a static struct. > > In order to avoid changing any of that, let's instead provide ever > so slightly better encapsulation of those struct fwnode_operations > instances. Those do not really need to be directly used in > inline function calls in header files. Simply moving two small > functions (is_acpi_device_node and is_acpi_data_node) out of > acpi_bus.h, and into a .c file, does that. > > That leaves the internals of struct fwnode_operations as GPL-only > (which I think was the intent all along), but un-breaks any driver > code out there that relies on the ACPI subsystem's being (historically) > an EXPORT_SYMBOL-usable system. By that, I mean, ACPI_HANDLE() and > other basic ACPI calls were non-GPL-protected. Works for me. Acked-by: Sakari Ailus <sakari.ailus@...ux.intel.com> OF appears to have the same effective change; Rob: let me know if you'd like me to send a patch for that, or whether this is preferred. On OF both appear to be used (EXPORT_SYMBOL / EXPORT_SYMBOL_GPL). -- Regards, Sakari Ailus sakari.ailus@...ux.intel.com
Powered by blists - more mailing lists