linux-kernel - [PATCH] cpupowerutils: bench

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 18 Sep 2017 17:14:26 +0530
From:   Abhishek Goel <huntbag@...ux.vnet.ibm.com>
To:     trenn@...e.com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Abhishek Goel <huntbag@...ux.vnet.ibm.com>
Subject: [PATCH] cpupowerutils: bench - Fix cpu online check

cpupower_is_cpu_online returns 1 when cpu is online. But in function
set_cpufreq_governor, it was incorrectly checking for 0 in case cpu is
online.

Signed-off-by: Abhishek Goel <huntbag@...ux.vnet.ibm.com>
---
 tools/power/cpupower/bench/system.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/power/cpupower/bench/system.c b/tools/power/cpupower/bench/system.c
index c25a74a..2bb3eef 100644
--- a/tools/power/cpupower/bench/system.c
+++ b/tools/power/cpupower/bench/system.c
@@ -61,7 +61,7 @@ int set_cpufreq_governor(char *governor, unsigned int cpu)
 
 	dprintf("set %s as cpufreq governor\n", governor);
 
-	if (cpupower_is_cpu_online(cpu) != 0) {
+	if (cpupower_is_cpu_online(cpu) != 1) {
 		perror("cpufreq_cpu_exists");
 		fprintf(stderr, "error: cpu %u does not exist\n", cpu);
 		return -1;
-- 
2.9.3