lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Sep 2017 15:57:35 +0300 From: Mikko Rapeli <mikko.rapeli@....fi> To: "Dmitry V. Levin" <ldv@...linux.org> Cc: linux-kernel@...r.kernel.org, linux-api@...r.kernel.org, Dave Watson <davejwatson@...com>, Ilya Lesokhin <ilyal@...lanox.com>, Aviad Yehezkel <aviadye@...lanox.com>, netdev@...r.kernel.org Subject: Re: [PATCH v06 35/36] uapi linux/tls.h: don't include <net/tcp.h> in user space On Mon, Sep 04, 2017 at 07:15:11PM +0300, Dmitry V. Levin wrote: > On Wed, Aug 09, 2017 at 02:25:54AM +0300, Dmitry V. Levin wrote: > > On Sun, Aug 06, 2017 at 06:44:26PM +0200, Mikko Rapeli wrote: > > > It is not needed and not part of uapi headers, but causes > > > user space compilation error: > > > > > > fatal error: net/tcp.h: No such file or directory > > > #include <net/tcp.h> > > > ^ > > > > > > Signed-off-by: Mikko Rapeli <mikko.rapeli@....fi> > > > Cc: Dave Watson <davejwatson@...com> > > > Cc: Ilya Lesokhin <ilyal@...lanox.com> > > > Cc: Aviad Yehezkel <aviadye@...lanox.com> > > > --- > > > include/uapi/linux/tls.h | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/include/uapi/linux/tls.h b/include/uapi/linux/tls.h > > > index cc1d21db35d8..d87c698623f2 100644 > > > --- a/include/uapi/linux/tls.h > > > +++ b/include/uapi/linux/tls.h > > > @@ -37,7 +37,9 @@ > > > #include <asm/byteorder.h> > > > #include <linux/socket.h> > > > #include <linux/tcp.h> > > > +#ifdef __KERNEL__ > > > #include <net/tcp.h> > > > +#endif > > > > Let's move it to include/net/tls.h instead. > > So everybody ignored this and *new* uapi header was released > in a totally unusable form along with v4.13. Should issues like these be filed into bugzilla instead? Maybe emails are easier to ignore than bugzilla tickets. -Mikko
Powered by blists - more mailing lists