linux-kernel - Re: [PATCH V2 1/4] vmbus: don't acquire the mutex in vmbus_hvsock_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Sep 2017 16:00:24 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     kys@...rosoft.com
Cc:     linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
        olaf@...fle.de, apw@...onical.com, vkuznets@...hat.com,
        jasowang@...hat.com, leann.ogasawara@...onical.com,
        marcelo.cerri@...onical.com, sthemmin@...rosoft.com,
        Haiyang Zhang <haiyangz@...rosoft.com>
Subject: Re: [PATCH V2 1/4] vmbus: don't acquire the mutex in
 vmbus_hvsock_device_unregister()

On Sun, Sep 17, 2017 at 08:54:16PM -0700, kys@...hange.microsoft.com wrote:
> From: Dexuan Cui <decui@...rosoft.com>
> 
> Due to commit 54a66265d675 ("Drivers: hv: vmbus: Fix rescind handling"),
> we need this patch to resolve the below deadlock:
> 
> after we get the mutex in vmbus_hvsock_device_unregister() and call
> vmbus_device_unregister() -> device_unregister() -> ... -> device_release()
> -> vmbus_device_release(), we'll get a deadlock, because
> vmbus_device_release() tries to get the same mutex.
> 
> Signed-off-by: Dexuan Cui <decui@...rosoft.com>
> Cc: K. Y. Srinivasan <kys@...rosoft.com>
> Cc: Haiyang Zhang <haiyangz@...rosoft.com>
> Cc: Stephen Hemminger <sthemmin@...rosoft.com>
> Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>

As every one of these patches had questions from me, please break them
up into different series, one for 4.14-final, and one for 4.15-rc1.

thanks,

greg k-h