linux-kernel - Re: [PATCH v2] s390/char: Fix cdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 18 Sep 2017 16:22:40 +0200
From:   Heiko Carstens <heiko.carstens@...ibm.com>
To:     Jean Delvare <jdelvare@...e.de>
Cc:     linux-s390@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Martin Schwidefsky <schwidefsky@...ibm.com>
Subject: Re: [PATCH v2] s390/char: Fix cdev_add usage

On Mon, Sep 18, 2017 at 11:13:13AM +0200, Jean Delvare wrote:
> Function cdev_add does set cdev->dev, so there is no point in setting
> it prior to calling this function.
> 
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Cc: Martin Schwidefsky <schwidefsky@...ibm.com>
> Cc: Heiko Carstens <heiko.carstens@...ibm.com>
> ---
> Untested. Changes since v1 (2016-07-13):
>  * Improved description
>  * Added a few blank lines to make the code more readable
> 
>  drivers/s390/char/tape_class.c |    3 +--
>  drivers/s390/char/vmlogrdr.c   |    4 ++--
>  drivers/s390/char/vmur.c       |    4 ++--
>  3 files changed, 5 insertions(+), 6 deletions(-)

Applied, however without the extra blank lines ;)
Thanks!