linux-kernel - Re: [PATCH 3/4] nvmem: remove inline in drivers/nvmem/core.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Sep 2017 16:02:21 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org,
        Masahiro Yamada <yamada.masahiro@...ionext.com>
Subject: Re: [PATCH 3/4] nvmem: remove inline in drivers/nvmem/core.c



On 18/09/17 15:09, Greg Kroah-Hartman wrote:
> On Mon, Sep 11, 2017 at 11:00:13AM +0200, srinivas.kandagatla@...aro.org wrote:
>> From: Masahiro Yamada <yamada.masahiro@...ionext.com>
>>
>> These two functions are defined in .c file, but called just once
>> (at least for now).  So, the compiler will fold them into their
>> callers even without the "inline" markers.
>>
>> However, this kind of optimization should not be done by hand.
>> It is compiler's judge after all.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>> ---
>>   drivers/nvmem/core.c | 7 +++----
>>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> This isn't really a bugfix, so should wait for 4.15-rc1.

No rush for this patch, we can take it in 4.15-rc1..

thanks,
srini
> 
> thanks,
> 
> greg k-h
>