lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Sep 2017 18:10:22 +0200 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: linux-media@...r.kernel.org, Bhumika Goyal <bhumirks@...il.com>, Hans Verkuil <hverkuil@...all.nl>, Mauro Carvalho Chehab <mchehab@...nel.org>, Sakari Ailus <sakari.ailus@...ux.intel.com> Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org Subject: [PATCH] [media] gspca: Delete two error messages for a failed memory allocation in gspca_dev_probe2() From: Markus Elfring <elfring@...rs.sourceforge.net> Date: Mon, 18 Sep 2017 17:47:58 +0200 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> --- drivers/media/usb/gspca/gspca.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/usb/gspca/gspca.c b/drivers/media/usb/gspca/gspca.c index 0f141762abf1..8be1c81b7cab 100644 --- a/drivers/media/usb/gspca/gspca.c +++ b/drivers/media/usb/gspca/gspca.c @@ -2037,10 +2037,8 @@ int gspca_dev_probe2(struct usb_interface *intf, - if (!gspca_dev) { - pr_err("couldn't kzalloc gspca struct\n"); + if (!gspca_dev) return -ENOMEM; - } + gspca_dev->usb_buf = kmalloc(USB_BUF_SZ, GFP_KERNEL); if (!gspca_dev->usb_buf) { - pr_err("out of memory\n"); ret = -ENOMEM; goto out; } -- 2.14.1
Powered by blists - more mailing lists