linux-kernel - RE: [PATCH v9] usb: serial: add vid:pid for Cypress WICED dev board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 18 Sep 2017 16:58:03 +0000
From:   Jeffrey Chu <Jeffrey.chu@...ress.com>
To:     Johan Hovold <johan@...nel.org>,
        "Sheng-Hui J. Chu" <jeffrey.chu@...look.com>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v9] usb: serial: add vid:pid for Cypress WICED dev board

Thanks,  -Jeffrey

-----Original Message-----
From: Johan Hovold [mailto:jhovold@...il.com] On Behalf Of Johan Hovold
Sent: Monday, September 18, 2017 4:41 AM
To: Sheng-Hui J. Chu <jeffrey.chu@...look.com>
Cc: gregkh@...uxfoundation.org; johan@...nel.org; linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org; Jeffrey Chu <Jeffrey.chu@...ress.com>
Subject: Re: [PATCH v9] usb: serial: add vid:pid for Cypress WICED dev board

On Fri, Sep 08, 2017 at 09:08:58PM +0000, Sheng-Hui J. Chu wrote:
> From: Jeffrey Chu <jeffrey.chu@...ress.com>
>
> Add CYPRESS_VID vid and CYPRESS_WICED_BT_USB and CYPRESS_WICED_WL_USB
> device IDs to ftdi_sio driver
>
> Signed-off-by: Jeffrey Chu <jeffrey.chu@...ress.com>

I have two v9 of this patch in my mailbox with different authorship and sent five minutes apart. I figured you really wanted this last one applied, but next time make sure to increase the patch revision (e.g.
mark it as v10) to avoid any confusion.

> ---
>  drivers/usb/serial/ftdi_sio.c     | 2 ++
>  drivers/usb/serial/ftdi_sio_ids.h | 7 +++++++
>  2 files changed, 9 insertions(+)
>
> diff --git a/drivers/usb/serial/ftdi_sio.c
> b/drivers/usb/serial/ftdi_sio.c index 1cec037..49d1b2d 100644
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -1015,6 +1015,8 @@ static const struct usb_device_id id_table_combined[] = {
>  { USB_DEVICE(WICED_VID, WICED_USB20706V2_PID) },
>  { USB_DEVICE(TI_VID, TI_CC3200_LAUNCHPAD_PID),
>  .driver_info = (kernel_ulong_t)&ftdi_jtag_quirk },
> +{ USB_DEVICE(CYPRESS_VID, CYPRESS_WICED_BT_USB_PID) },
> +{ USB_DEVICE(CYPRESS_VID, CYPRESS_WICED_WL_USB_PID) },
>  { }/* Terminating entry */
>  };
>
> diff --git a/drivers/usb/serial/ftdi_sio_ids.h
> b/drivers/usb/serial/ftdi_sio_ids.h
> index 4fcf1ce..d58dc1b 100644
> --- a/drivers/usb/serial/ftdi_sio_ids.h
> +++ b/drivers/usb/serial/ftdi_sio_ids.h
> @@ -692,6 +692,13 @@
>  #define WICED_USB20706V2_PID0x6422
>
>  /*
> + * Cypress WICED USB UART
> + */
> +#define CYPRESS_VID0x04B4
> +#define CYPRESS_WICED_BT_USB_PID0x009B
> +#define CYPRESS_WICED_WL_USB_PID0xF900
> +
> +/*
>   * Definitions for ID TECH (www.idt-net.com) devices
>   */
>  #define IDTECH_VID0x0ACD/* ID TECH Vendor ID */

I've applied this one now with some minor tweaks (e.g. kept the define sections sorted by VID, and adjusted the commit message slightly).

Thanks,
Johan

This message and any attachments may contain confidential information from Cypress or its subsidiaries. If it has been received in error, please advise the sender and immediately delete this message.