linux-kernel - Re: [PATCH] drm: pl111: constify amba

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87shfjsypy.fsf@anholt.net>
Date:   Mon, 18 Sep 2017 10:28:25 -0700
From:   Eric Anholt <eric@...olt.net>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, airlied@...ux.ie
Cc:     linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm: pl111: constify amba_id

Arvind Yadav <arvind.yadav.cs@...il.com> writes:

> amba_id are not supposed to change at runtime. All functions
> working with const amba_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  drivers/gpu/drm/pl111/pl111_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c
> index ac8771b..522875c 100644
> --- a/drivers/gpu/drm/pl111/pl111_drv.c
> +++ b/drivers/gpu/drm/pl111/pl111_drv.c
> @@ -243,7 +243,7 @@ static int pl111_amba_remove(struct amba_device *amba_dev)
>  	return 0;
>  }
>  
> -static struct amba_id pl111_id_table[] = {
> +static const struct amba_id pl111_id_table[] = {
>  	{
>  		.id = 0x00041111,
>  		.mask = 0x000fffff,
> -- 
> 2.7.4

Sorry about dropping your patch here -- Linus was working on a bigger
series for pl110 support that also happened to fix this.

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)