lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Sep 2017 13:38:30 -0700 From: "Darrick J. Wong" <darrick.wong@...cle.com> To: Colin King <colin.king@...onical.com> Cc: linux-xfs@...r.kernel.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] xfs: remove redundant re-initialization of total_nr_pages On Mon, Sep 18, 2017 at 01:01:57PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@...onical.com> > > Variable total_nr_pages is being initialized and then updated with > the same value, this latter assignment is redundant and can be > removed. Cleans up clang build warning: > > Value stored to 'total_nr_pages' during its initialization is never read > > Signed-off-by: Colin Ian King <colin.king@...onical.com> Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com> > --- > fs/xfs/xfs_buf.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c > index da14658da310..2f97c12ca75e 100644 > --- a/fs/xfs/xfs_buf.c > +++ b/fs/xfs/xfs_buf.c > @@ -1258,8 +1258,6 @@ xfs_buf_ioapply_map( > int size; > int offset; > > - total_nr_pages = bp->b_page_count; > - > /* skip the pages in the buffer before the start offset */ > page_index = 0; > offset = *buf_offset; > -- > 2.14.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists