lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Sep 2017 15:40:13 -0500 From: Alan Tull <atull@...nel.org> To: Moritz Fischer <mdf@...nel.org> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-fpga@...r.kernel.org, linux-kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 1/2] fpga: altera-cvp: remove DRIVER_ATTR() usage On Mon, Sep 18, 2017 at 11:42 AM, Moritz Fischer <mdf@...nel.org> wrote: > On Mon, Sep 18, 2017 at 12:17:36PM +0200, Greg Kroah-Hartman wrote: >> It's better to be explicit and use the DRIVER_ATTR_RW() macro when >> defining a driver's sysfs file. >> >> This is part of a series to drop DRIVER_ATTR() from the tree entirely. >> >> Cc: Alan Tull <atull@...nel.org> >> Cc: Moritz Fischer <mdf@...nel.org> >> Cc: linux-fpga@...r.kernel.org >> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> > Acked-by: Moritz Fischer <mdf@...nel.org> Acked-by: Alan Tull <atull@...nel.org> >> --- >> drivers/fpga/altera-cvp.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/fpga/altera-cvp.c b/drivers/fpga/altera-cvp.c >> index 08629ee69d11..00e73d28077c 100644 >> --- a/drivers/fpga/altera-cvp.c >> +++ b/drivers/fpga/altera-cvp.c >> @@ -361,12 +361,12 @@ static const struct fpga_manager_ops altera_cvp_ops = { >> .write_complete = altera_cvp_write_complete, >> }; >> >> -static ssize_t show_chkcfg(struct device_driver *dev, char *buf) >> +static ssize_t chkcfg_show(struct device_driver *dev, char *buf) >> { >> return snprintf(buf, 3, "%d\n", altera_cvp_chkcfg); >> } >> >> -static ssize_t store_chkcfg(struct device_driver *drv, const char *buf, >> +static ssize_t chkcfg_store(struct device_driver *drv, const char *buf, >> size_t count) >> { >> int ret; >> @@ -378,7 +378,7 @@ static ssize_t store_chkcfg(struct device_driver *drv, const char *buf, >> return count; >> } >> >> -static DRIVER_ATTR(chkcfg, 0600, show_chkcfg, store_chkcfg); >> +static DRIVER_ATTR_RW(chkcfg); >> >> static int altera_cvp_probe(struct pci_dev *pdev, >> const struct pci_device_id *dev_id); >> -- >> 2.14.1 >>
Powered by blists - more mailing lists