linux-kernel - Re: [PATCH V5 1/3] dma-mapping: Introduce device_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170918052245.GC29118@infradead.org>
Date:   Sun, 17 Sep 2017 22:22:45 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Huacai Chen <chenhc@...ote.com>
Cc:     Marek Szyprowski <m.szyprowski@...sung.com>,
        Robin Murphy <robin.murphy@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Fuxin Zhang <zhangfx@...ote.com>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH V5 1/3] dma-mapping: Introduce device_is_coherent() as a
 helper

On Mon, Sep 18, 2017 at 12:21:40PM +0800, Huacai Chen wrote:
> We will use device_is_coherent() as a helper function, in order to set
> an appropriate dma alignment in dmapool and block queue (other patches
> in this series).
> 
> There is a MIPS-specific plat_device_is_coherent(), but we need a more
> generic solution, so add and use a new function pointer in dma_map_ops.

This is still missing any explanation on what this API could do
with the information, and both of the callers in the series don't
actually need it.