linux-kernel - Re: [PATCH 1/2] [RESEND] of: provide of_n_{addr,size}_cells wrappers for !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdWQu8HVp2jc2qcs=vUuiBNdOMm96qSgTpJSNqTtm2gO5A@mail.gmail.com>
Date:   Tue, 19 Sep 2017 09:02:59 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Rob Herring <robh+dt@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Frank Rowand <frowand.list@...il.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Magnus Damm <damm@...nsource.se>,
        Ben Dooks <ben.dooks@...ethink.co.uk>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        SH-Linux <linux-sh@...r.kernel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] [RESEND] of: provide of_n_{addr,size}_cells wrappers
 for !CONFIG_OF

Hi Rob,

On Mon, Sep 18, 2017 at 11:28 PM, Rob Herring <robh+dt@...nel.org> wrote:
> On Mon, Sep 11, 2017 at 3:07 PM, Arnd Bergmann <arnd@...db.de> wrote:
>> The pci-rcar driver is enabled for compile tests, and this has
>> shown that the driver cannot build without CONFIG_OF,
>> following the inclusion of f8f2fe7355fb "PCI: rcar: Use new OF
>> interrupt mapping when possible":
>>
>> drivers/pci/host/pcie-rcar.c: In function 'pci_dma_range_parser_init':
>> drivers/pci/host/pcie-rcar.c:1039:2: error: implicit declaration of function 'of_n_addr_cells' [-Werror=implicit-function-declaration]
>>   parser->pna = of_n_addr_cells(node);
>>   ^
>> As pointed out by Ben Dooks and Geert Uytterhoeven, this is actually
>> supposed to build fine, which we can achieve if we make the
>> declaration of of_irq_parse_and_map_pci conditional on CONFIG_OF
>> and provide an empty inline function otherwise, as we do for
>> a lot of other of interfaces.
>>
>> This lets us build the rcar_pci driver again without CONFIG_OF
>> for build testing. All platforms using this driver select OF,
>> so this doesn't change anything for the users.
>
> Sorry, I keep missing this. It's a flaw in my mail filtering...
>
> There's a patch series[1] to factor out pci_dma_range_parser_init of
> the driver which should also fix this. I'd prefer not to take this
> because ideally all address parsing should be within the DT core code.
>
> Rob
>
> [1] https://patchwork.kernel.org/patch/9927541/

Yes, that looks like a better solution.

(For those who didn't see the rest of the series: of_pci_dma_range_parser_init()
 in provided in of/address.c, and does have a dummy)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds