linux-kernel - Re: [PATCH v2 1/2] mfd: fsl-imx25: set irq handler and data in one go

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1505809055.20966.5.camel@pengutronix.de>
Date:   Tue, 19 Sep 2017 10:17:35 +0200
From:   Lucas Stach <l.stach@...gutronix.de>
To:     Martin Kaiser <martin@...ser.cx>
Cc:     Lee Jones <lee.jones@...aro.org>, kernel@...gutronix.de,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] mfd: fsl-imx25: set irq handler and data in one
 go

Am Dienstag, den 19.09.2017, 08:23 +0200 schrieb Martin Kaiser:
> Replace the two separate calls for setting the irq handler and data with
> a single irq_set_chained_handler_and_data() call.
> 
> Signed-off-by: Martin Kaiser <martin@...ser.cx>

Reviewed-by: Lucas Stach <l.stach@...gutronix.de>

> ---
> changes in v2: none
> 
>  drivers/mfd/fsl-imx25-tsadc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/fsl-imx25-tsadc.c b/drivers/mfd/fsl-imx25-tsadc.c
> index b3767c3..14189ef 100644
> --- a/drivers/mfd/fsl-imx25-tsadc.c
> +++ b/drivers/mfd/fsl-imx25-tsadc.c
> @@ -84,8 +84,7 @@ static int mx25_tsadc_setup_irq(struct platform_device *pdev,
>  		return -ENOMEM;
>  	}
>  
> -	irq_set_chained_handler(irq, mx25_tsadc_irq_handler);
> -	irq_set_handler_data(irq, tsadc);
> +	irq_set_chained_handler_and_data(irq, mx25_tsadc_irq_handler, tsadc);
>  
>  	return 0;
>  }