linux-kernel - Re: [PATCH] thermal: imx: add NVMEM dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a3=bGhjwvyMCEAz3UrBZmEst+XBFpAdYsyrr+ppHg2t7w@mail.gmail.com>
Date:   Tue, 19 Sep 2017 14:22:36 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Leonard Crestez <leonard.crestez@....com>
Cc:     Zhang Rui <rui.zhang@...el.com>,
        Eduardo Valentin <edubezval@...il.com>,
        Shawn Guo <shawnguo@...nel.org>, linux-pm@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] thermal: imx: add NVMEM dependency

On Tue, Sep 19, 2017 at 12:53 PM, Leonard Crestez
<leonard.crestez@....com> wrote:
> On Mon, 2017-09-18 at 22:48 +0200, Arnd Bergmann wrote:
>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
>> index 07002df4f83a..cb14f1ec5953 100644
>> --- a/drivers/thermal/Kconfig
>> +++ b/drivers/thermal/Kconfig
>> @@ -206,6 +206,7 @@ config HISI_THERMAL
>>  config IMX_THERMAL
>>       tristate "Temperature sensor driver for Freescale i.MX SoCs"
>>       depends on (ARCH_MXC && CPU_THERMAL) || COMPILE_TEST
>> +     depends on NVMEM || !NVMEM
>
> The || !NVMEM part is so that it also works when NVMEM=n, right?

Correct, this is a very strange Kconfig expression when you see it the
first time, but we do the same thing in a lot of places that can either
use another subsystem when it is enabled (but have a link-time
dependency), or can work fine without it.

      Arnd