linux-kernel - Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate %pF/%pf printk specifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1e7c2b0-8c52-7e21-b311-d886f5c4c20e@gmx.de>
Date:   Tue, 19 Sep 2017 16:07:17 +0200
From:   Helge Deller <deller@....de>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        "Luck, Tony" <tony.luck@...el.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        "James E . J . Bottomley" <jejb@...isc-linux.org>,
        Petr Mladek <pmladek@...e.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jessica Yu <jeyu@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        linux-ia64@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate
 %pF/%pf printk specifiers

On 19.09.2017 04:05, Sergey Senozhatsky wrote:
> On (09/18/17 20:39), Helge Deller wrote:
>> I did tried your testcases [on parisc] too.
...
>> and here is "modprobe zram":
>>   printk#7 __UNIQUE_ID_vermagic8+0xb9a4/0xbd04 [zram]
>>   printk#8 __UNIQUE_ID_vermagic8+0xb9a4/0xbd04 [zram]
>>   printk#9 do_one_initcall+0x194/0x290
>>   printk#10 do_one_initcall+0x194/0x290
>>   printk#11 do_one_initcall+0x194/0x290
>>   printk#12 do_one_initcall+0x194/0x290
>>   printk#13 zram_init+0x22c/0x2a0 [zram]
>>   printk#14 zram_init+0x22c/0x2a0 [zram]
>>   printk#15 zram_init+0x22c/0x2a0 [zram]
>>   printk#16 zram_init+0x22c/0x2a0 [zram]
>>
>> I wonder why printk#7 and printk#8 don't show "zram_init"...
> 
> interesting... what does the unpatched kernel show?

Really strange.
The unpatched kernel shows __UNIQUE_ID_vermagic8+0xb9a4/0xbd04 too.
The symbol should be known, because later on in printk13 it shows correctly zram_init.
I'll need to dig deeper into it, but at least the regression is not due
to your patch.

Helge