linux-kernel - Re: [PATCH] btrfs: make array types static const, reduces object code size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170919150906.GG29043@twin.jikos.cz>
Date:   Tue, 19 Sep 2017 17:09:06 +0200
From:   David Sterba <dsterba@...e.cz>
To:     Colin King <colin.king@...onical.com>
Cc:     Chris Mason <clm@...com>, Josef Bacik <jbacik@...com>,
        David Sterba <dsterba@...e.com>, linux-btrfs@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: make array types static const, reduces object
 code size

On Tue, Sep 19, 2017 at 04:01:23PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Don't populate the read-only array types on the stack, instead make
> it static const.  Makes the object code smaller by nearly 60 bytes:
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>   90536	   6552	     64	  97152	  17b80	fs/btrfs/ioctl.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>   90414	   6616	     64	  97094	  17b46	fs/btrfs/ioctl.o
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: David Sterba <dsterba@...e.com>