linux-kernel - Re: [PATCH] sysctl: remove duplicate UINT_MAX check on do_proc_douintvec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKkzCapdi6PxnJLHrViSULoKuWL-eeY8VxSQ3369R5zUg@mail.gmail.com>
Date:   Tue, 19 Sep 2017 14:52:30 -0700
From:   Kees Cook <keescook@...omium.org>
To:     "Luis R. Rodriguez" <mcgrof@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        David Binderman <dcb314@...mail.com>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sysctl: remove duplicate UINT_MAX check on do_proc_douintvec_conv()

On Tue, Sep 19, 2017 at 12:29 AM, Luis R. Rodriguez <mcgrof@...nel.org> wrote:
> do_proc_douintvec_conv() has two UINT_MAX checks, we can remove one.
> This has no functional changes other than fixing a compiler warning:
>
> kernel/sysctl.c:2190]: (warning) Identical condition '*lvalp>UINT_MAX', second condition is always false
>
> Reported-by: David Binderman <dcb314@...mail.com>
> Signed-off-by: Luis R. Rodriguez <mcgrof@...nel.org>

Fixes: 4f2fec00afa60 ("sysctl: simplify unsigned int support")
Acked-by: Kees Cook <keescook@...omium.org>

-Kees

> ---
>  kernel/sysctl.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index 4c08ed4a379e..0da31bbbff18 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -2181,8 +2181,6 @@ static int do_proc_douintvec_conv(unsigned long *lvalp,
>                                   int write, void *data)
>  {
>         if (write) {
> -               if (*lvalp > UINT_MAX)
> -                       return -EINVAL;
>                 if (*lvalp > UINT_MAX)
>                         return -EINVAL;
>                 *valp = *lvalp;
> --
> 2.14.0
>



-- 
Kees Cook
Pixel Security