linux-kernel - Re: [PATCH] libata: make static arrays const, reduces object code size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170919032956.GP378890@devbig577.frc2.facebook.com>
Date:   Mon, 18 Sep 2017 20:29:56 -0700
From:   Tejun Heo <tj@...nel.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Mark Fasheh <mfasheh@...sity.com>,
        Joel Becker <jlbec@...lplan.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        piaojun <piaojun@...wei.com>, linux-ide@...r.kernel.org,
        ocfs2-devel@....oracle.com, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libata: make static arrays const, reduces object code
 size

On Mon, Sep 18, 2017 at 02:31:40PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Don't populate const arrayis on the stack, instead make them static.
> Makes the object code smaller by over 260 bytes:
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
...
> diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
> index 74407c6dd592..31a61e8e0152 100644
> --- a/fs/ocfs2/dlm/dlmrecovery.c
> +++ b/fs/ocfs2/dlm/dlmrecovery.c
> @@ -1129,7 +1129,6 @@ static int dlm_send_mig_lockres_msg(struct dlm_ctxt *dlm,
>  		(mres->num_locks * sizeof(struct dlm_migratable_lock));
>  
>  	/* add an all-done flag if we reached the last lock */
> -	orig_flags = mres->flags;
>  	BUG_ON(total_locks > mres_total_locks);
>  	if (total_locks == mres_total_locks)
>  		mres->flags |= DLM_MRES_ALL_DONE;

Looks like patch contamination.

Thanks.

-- 
tejun