linux-kernel - Re: [tip:timers/core] kselftests: timers: set-timer-lat: Tweak reporting when timer fires early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <04d5e9e4-ef81-a9e7-8180-2c668e3af9d0@kernel.org>
Date:   Tue, 19 Sep 2017 19:02:41 -0600
From:   Shuah Khan <shuah@...nel.org>
To:     linux-kernel@...r.kernel.org, richardcochran@...il.com,
        hpa@...or.com, tglx@...utronix.de, mingo@...nel.org,
        john.stultz@...aro.org, prarit@...hat.com, stephen.boyd@...aro.org,
        ghackmann@...gle.com, mlichvar@...hat.com,
        linux-tip-commits@...r.kernel.org,
        Shuah Khan <shuahkh@....samsung.com>
Cc:     Shuah Khan <shuah@...nel.org>
Subject: Re: [tip:timers/core] kselftests: timers: set-timer-lat: Tweak
 reporting when timer fires early

Hi Greg,

On 08/20/2017 03:56 AM, tip-bot for Greg Hackmann wrote:
> Commit-ID:  a524b1184b8e86141d689fa78ad150fbf2db9b4c
> Gitweb:     http://git.kernel.org/tip/a524b1184b8e86141d689fa78ad150fbf2db9b4c
> Author:     Greg Hackmann <ghackmann@...gle.com>
> AuthorDate: Tue, 25 Jul 2017 14:36:25 -0700
> Committer:  John Stultz <john.stultz@...aro.org>
> CommitDate: Thu, 17 Aug 2017 12:14:54 -0700
> 
> kselftests: timers: set-timer-lat: Tweak reporting when timer fires early
> 
> Rather than printing an error inside the alarm signal handler, set a
> flag that we check later.  This keeps the test from spamming the console
> every time the alarm fires early.  It also fixes the test exiting with
> error code 0 if this was the only test failure.
> 
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: Miroslav Lichvar <mlichvar@...hat.com>
> Cc: Richard Cochran <richardcochran@...il.com>
> Cc: Prarit Bhargava <prarit@...hat.com>
> Cc: Stephen Boyd <stephen.boyd@...aro.org>
> Cc: Shuah Khan <shuah@...nel.org>
> Cc: linux-kselftest@...r.kernel.org
> Signed-off-by: Greg Hackmann <ghackmann@...gle.com>
> Signed-off-by: John Stultz <john.stultz@...aro.org>

This commit is making the set-timer-lat hang. I reverted this commit
and there is no hang. Could you please take a look and see if this
commit should be reverted.

make kselftest as well as make -C tools/testing/selftests/timers run_tests
hang.

I had to revert the following as well, however a524b1184b8e86141d689fa78ad150fbf2db9b4c
is the suspect.

Commit-ID:  28be3f8f48cfb3cf024860f042d424cd4824f5f7
Gitweb:     http://git.kernel.org/tip/28be3f8f48cfb3cf024860f042d424cd4824f5f7
Author:     Greg Hackmann <ghackmann@...gle.com>
AuthorDate: Tue, 25 Jul 2017 14:36:26 -0700
Committer:  John Stultz <john.stultz@...aro.org>
CommitDate: Thu, 17 Aug 2017 12:14:58 -0700

kselftests: timers: set-timer-lat: Add one-shot timer test cases

Please let me know how you want to proceed. At the moment kselftest
run hangs due this test hang.

thanks,
-- Shuah