linux-kernel - Re: [PATCH] dmaengine: sun6i: sun4i-gpadc: use of_device_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170920072122.GA19920@Red>
Date:   Wed, 20 Sep 2017 09:21:22 +0200
From:   Corentin Labbe <clabbe.montjoie@...il.com>
To:     Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc:     vinod.koul@...el.com, dan.j.williams@...el.com, wens@...e.org,
        dmaengine@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: sun6i: sun4i-gpadc: use
 of_device_get_match_data

On Wed, Sep 20, 2017 at 08:58:14AM +0200, Maxime Ripard wrote:
> Hi,
> 
> On Tue, Sep 19, 2017 at 06:44:47PM +0000, Corentin Labbe wrote:
> > The usage of of_device_get_match_data reduce the code size a bit.
> > Furthermore, it prevents an improbable dereference when
> > of_match_device() return NULL.
> > 
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>
> 
> The prefix of your commit title is wrong, this isn't about the GPADC.
> 
> Once fixed,
> Acked-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> 
> Maxime
> 

A copy/paste error, sorry
I will resend
thanks
Corentin Labbe