linux-kernel - Re: [PATCH] KVM: x86: Fix the NULL pointer parameter in check_cr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f652327-03f4-5fba-0717-d1f29e45d6cf@redhat.com>
Date:   Wed, 20 Sep 2017 10:13:54 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Yu Zhang <yu.c.zhang@...ux.intel.com>,
        Jim Mattson <jmattson@...gle.com>,
        David Hildenbrand <david@...hat.com>
Cc:     kvm list <kvm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] KVM: x86: Fix the NULL pointer parameter in
 check_cr_write()

On 20/09/2017 08:35, Yu Zhang wrote:
> 
> 2 reasons I did not choose to change kvm_cpuid(): 1> like Jim's
> comments, kvm_cpuid() will eventually write the *eax - *edx no
> matter a cpuid entry is found or not; 2> currently, return value of
> kvm_cpuid() is either true when an entry is found or false otherwise.
> We can change kvm_cpuid() to check the pointers of GPRs against NULL
> and return false immediately. Then the false value would have 2
> different meanings - entry not found, or invalid params.
> 
> Paolo, any suggestion? :-)

Radim, has already sent this version to Linus. :)

Paolo