linux-kernel - Re: [PATCH 6/7] cpufreq: make cpufreq_generic_init transition_latency default to CPUFREQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170920144538.GK30848@ubuntu>
Date:   Wed, 20 Sep 2017 07:45:38 -0700
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Dong Aisheng <dongas86@...il.com>
Cc:     Dong Aisheng <aisheng.dong@....com>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        sboyd@...eaurora.org, vireshk@...nel.org, nm@...com,
        rjw@...ysocki.net, shawnguo@...nel.org, Anson.Huang@....com,
        ping.bai@....com
Subject: Re: [PATCH 6/7] cpufreq: make cpufreq_generic_init
 transition_latency default to CPUFREQ_ETERNAL

On 20-09-17, 15:04, Dong Aisheng wrote:
> On Tue, Sep 19, 2017 at 04:10:07PM -0700, Viresh Kumar wrote:
> > On 24-08-17, 00:10, Dong Aisheng wrote:
> > > If no valid transition_latency specified, let's make it default to
> > > CPUFREQ_ETERNAL which is consistent with its definition.
> > > 
> > > This can save some of the same checkings like this:
> > >         transition_latency = dev_pm_opp_get_max_transition_latency(cpu_dev);
> > > -       if (!transition_latency)
> > > -               transition_latency = CPUFREQ_ETERNAL;
> > >         ret = cpufreq_generic_init(policy, freq_table, transition_latency);
> > > 
> > > Cc: Viresh Kumar <vireshk@...nel.org>
> > > Cc: Nishanth Menon <nm@...com>
> > > Cc: Stephen Boyd <sboyd@...eaurora.org>
> > > Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> > > Signed-off-by: Dong Aisheng <aisheng.dong@....com>
> > > ---
> > >  drivers/cpufreq/cpufreq.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > > index 9bf97a3..da07de6 100644
> > > --- a/drivers/cpufreq/cpufreq.c
> > > +++ b/drivers/cpufreq/cpufreq.c
> > > @@ -180,6 +180,8 @@ int cpufreq_generic_init(struct cpufreq_policy *policy,
> > >  		return ret;
> > >  	}
> > >  
> > > +	if (!transition_latency)
> > > +		transition_latency = CPUFREQ_ETERNAL;
> > >  	policy->cpuinfo.transition_latency = transition_latency;
> > >  
> > >  	/*
> > 
> > Can you update all the existing drivers as well (in the same patch)
> > who can benefit from it?
> 
> Yes, of course.
> Will do it in the updated version later.

Perhaps you can send it separately if you want as your series is
surely going to take some time to get merged.

-- 
viresh