linux-kernel - Re: [PATCH] selinux: Use kmem_cache for hashtab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 20 Sep 2017 12:09:16 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Kyeongdon Kim <kyeongdon.kim@....com>
Cc:     Stephen Smalley <sds@...ho.nsa.gov>,
        Eric Paris <eparis@...isplace.org>,
        James Morris <james.l.morris@...cle.com>, serge@...lyn.com,
        elfring@...rs.sourceforge.net, danielj@...lanox.com,
        junil0814.lee@....com, mka@...omium.org, selinux@...ho.nsa.gov,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selinux: Use kmem_cache for hashtab_node

On Thu, Sep 7, 2017 at 7:18 PM, Paul Moore <paul@...l-moore.com> wrote:
> On Wed, Sep 6, 2017 at 5:50 AM, Kyeongdon Kim <kyeongdon.kim@....com> wrote:
>> During random test as own device to check slub account,
>> we found some slack memory from hashtab_node(kmalloc-64).
>> By using kzalloc(), middle of test result like below:
>> allocated size 240768
>> request size 45144
>> slack size 195624
>> allocation count 3762
>>
>> So, we want to use kmem_cache_zalloc() and that
>> can reduce memory size 52byte(slack size/alloc count) per each struct.
>>
>> Signed-off-by: Kyeongdon Kim <kyeongdon.kim@....com>
>> ---
>>  security/selinux/ss/hashtab.c  | 17 +++++++++++++++--
>>  security/selinux/ss/hashtab.h  |  4 ++++
>>  security/selinux/ss/services.c |  4 ++++
>>  3 files changed, 23 insertions(+), 2 deletions(-)
>
> This seems reasonale, but I'm going to refrain from merging this until
> after the merge window closes.

I just merged this into selinux/next, thanks for your patience.

-- 
paul moore
www.paul-moore.com