linux-kernel - Re: [PATCH v4 02/13] xen/pvcalls: implement frontend disconnect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f24ec66-d370-5f2f-3c6a-8e949c8ed074@oracle.com>
Date:   Wed, 20 Sep 2017 16:32:32 -0400
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Stefano Stabellini <sstabellini@...nel.org>,
        xen-devel@...ts.xen.org
Cc:     linux-kernel@...r.kernel.org, jgross@...e.com,
        Stefano Stabellini <stefano@...reto.com>
Subject: Re: [PATCH v4 02/13] xen/pvcalls: implement frontend disconnect


> +
> +struct pvcalls_bedata {
> +	struct xen_pvcalls_front_ring ring;
> +	grant_ref_t ref;
> +	int irq;
> +
> +	struct list_head socket_mappings;
> +	struct list_head socketpass_mappings;
> +	spinlock_t socket_lock;
> +
> +	wait_queue_head_t inflight_req;
> +	struct xen_pvcalls_response rsp[PVCALLS_NR_REQ_PER_RING];
> +};
> +static struct xenbus_device *pvcalls_front_dev;
> +static atomic_t pvcalls_refcount;

Should the refcount be per back/frontend?

> +
> +/* first increment refcount, then proceed */
> +#define pvcalls_enter {                     \
> +	atomic_inc(&pvcalls_refcount);      \
> +	smp_mb();                           \
> +}
> +
> +/* first complete other operations, then decrement refcount */
> +#define pvcalls_exit {                      \
> +	smp_mb();                           \
> +	atomic_dec(&pvcalls_refcount);      \
> +}

I think atomic increment/decrement imply a barrier.


-boris