linux-kernel - Re: [PATCH] init/version: include <linux/export.h> instead of <linux/module.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170920205519.GM3007@windriver.com>
Date:   Wed, 20 Sep 2017 16:55:19 -0400
From:   Paul Gortmaker <paul.gortmaker@...driver.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
CC:     Andrew Morton <akpm@...ux-foundation.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] init/version: include <linux/export.h> instead of
 <linux/module.h>

[[PATCH] init/version: include <linux/export.h> instead of <linux/module.h>] On 21/09/2017 (Thu 00:23) Masahiro Yamada wrote:

> init/version.c has nothing to do with module, so remove
> the <linux/modude.h>.
> 
> Instead, include <linux/export.h> for EXPORT_SYMBOL_GPL.

I checked and there weren't any __init lurking in that file which is the
usual other required replacement (<linux/init.h>) so this should be
fine.

Paul.
--

> 
> This cuts off a lot of unnecessary header parsing.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
>  init/version.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/init/version.c b/init/version.c
> index 5606341..bfb4e3f 100644
> --- a/init/version.c
> +++ b/init/version.c
> @@ -7,7 +7,7 @@
>   */
>  
>  #include <generated/compile.h>
> -#include <linux/module.h>
> +#include <linux/export.h>
>  #include <linux/uts.h>
>  #include <linux/utsname.h>
>  #include <generated/utsrelease.h>
> -- 
> 2.7.4
>