linux-kernel - Re: [PATCH 1/2] sched: Introduce new flags to sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <201709211417.PbdbQZWF%fengguang.wu@intel.com>
Date:   Thu, 21 Sep 2017 14:34:54 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Rohit Jain <rohit.k.jain@...cle.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        eas-dev@...ts.linaro.org, peterz@...radead.org, mingo@...hat.com,
        joelaf@...gle.com
Subject: Re: [PATCH 1/2] sched: Introduce new flags to sched_setaffinity to
 support soft affinity.

Hi Rohit,

[auto build test ERROR on tip/sched/core]
[also build test ERROR on v4.14-rc1 next-20170920]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Rohit-Jain/sched-Introduce-new-flags-to-sched_setaffinity-to-support-soft-affinity/20170921-140313
config: i386-randconfig-x018-201738 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   kernel//trace/trace_hwlat.c: In function 'move_to_next_cpu':
>> kernel//trace/trace_hwlat.c:299:2: error: too few arguments to function 'sched_setaffinity'
     sched_setaffinity(0, current_mask);
     ^~~~~~~~~~~~~~~~~
   In file included from include/linux/kthread.h:5:0,
                    from kernel//trace/trace_hwlat.c:42:
   include/linux/sched.h:1636:13: note: declared here
    extern long sched_setaffinity(pid_t pid, const struct cpumask *new_mask,
                ^~~~~~~~~~~~~~~~~
   kernel//trace/trace_hwlat.c: In function 'start_kthread':
   kernel//trace/trace_hwlat.c:372:2: error: too few arguments to function 'sched_setaffinity'
     sched_setaffinity(kthread->pid, current_mask);
     ^~~~~~~~~~~~~~~~~
   In file included from include/linux/kthread.h:5:0,
                    from kernel//trace/trace_hwlat.c:42:
   include/linux/sched.h:1636:13: note: declared here
    extern long sched_setaffinity(pid_t pid, const struct cpumask *new_mask,
                ^~~~~~~~~~~~~~~~~

vim +/sched_setaffinity +299 kernel//trace/trace_hwlat.c

0330f7aa Steven Rostedt (Red Hat  2016-07-15  269) 
f447c196 Steven Rostedt (VMware   2017-01-31  270) static void move_to_next_cpu(void)
0330f7aa Steven Rostedt (Red Hat  2016-07-15  271) {
f447c196 Steven Rostedt (VMware   2017-01-31  272) 	struct cpumask *current_mask = &save_cpumask;
0330f7aa Steven Rostedt (Red Hat  2016-07-15  273) 	int next_cpu;
0330f7aa Steven Rostedt (Red Hat  2016-07-15  274) 
0330f7aa Steven Rostedt (Red Hat  2016-07-15  275) 	if (disable_migrate)
0330f7aa Steven Rostedt (Red Hat  2016-07-15  276) 		return;
0330f7aa Steven Rostedt (Red Hat  2016-07-15  277) 	/*
0330f7aa Steven Rostedt (Red Hat  2016-07-15  278) 	 * If for some reason the user modifies the CPU affinity
0330f7aa Steven Rostedt (Red Hat  2016-07-15  279) 	 * of this thread, than stop migrating for the duration
0330f7aa Steven Rostedt (Red Hat  2016-07-15  280) 	 * of the current test.
0330f7aa Steven Rostedt (Red Hat  2016-07-15  281) 	 */
0330f7aa Steven Rostedt (Red Hat  2016-07-15  282) 	if (!cpumask_equal(current_mask, &current->cpus_allowed))
0330f7aa Steven Rostedt (Red Hat  2016-07-15  283) 		goto disable;
0330f7aa Steven Rostedt (Red Hat  2016-07-15  284) 
0330f7aa Steven Rostedt (Red Hat  2016-07-15  285) 	get_online_cpus();
0330f7aa Steven Rostedt (Red Hat  2016-07-15  286) 	cpumask_and(current_mask, cpu_online_mask, tracing_buffer_mask);
0330f7aa Steven Rostedt (Red Hat  2016-07-15  287) 	next_cpu = cpumask_next(smp_processor_id(), current_mask);
0330f7aa Steven Rostedt (Red Hat  2016-07-15  288) 	put_online_cpus();
0330f7aa Steven Rostedt (Red Hat  2016-07-15  289) 
0330f7aa Steven Rostedt (Red Hat  2016-07-15  290) 	if (next_cpu >= nr_cpu_ids)
0330f7aa Steven Rostedt (Red Hat  2016-07-15  291) 		next_cpu = cpumask_first(current_mask);
0330f7aa Steven Rostedt (Red Hat  2016-07-15  292) 
0330f7aa Steven Rostedt (Red Hat  2016-07-15  293) 	if (next_cpu >= nr_cpu_ids) /* Shouldn't happen! */
0330f7aa Steven Rostedt (Red Hat  2016-07-15  294) 		goto disable;
0330f7aa Steven Rostedt (Red Hat  2016-07-15  295) 
0330f7aa Steven Rostedt (Red Hat  2016-07-15  296) 	cpumask_clear(current_mask);
0330f7aa Steven Rostedt (Red Hat  2016-07-15  297) 	cpumask_set_cpu(next_cpu, current_mask);
0330f7aa Steven Rostedt (Red Hat  2016-07-15  298) 
0330f7aa Steven Rostedt (Red Hat  2016-07-15 @299) 	sched_setaffinity(0, current_mask);
0330f7aa Steven Rostedt (Red Hat  2016-07-15  300) 	return;
0330f7aa Steven Rostedt (Red Hat  2016-07-15  301) 
0330f7aa Steven Rostedt (Red Hat  2016-07-15  302)  disable:
0330f7aa Steven Rostedt (Red Hat  2016-07-15  303) 	disable_migrate = true;
0330f7aa Steven Rostedt (Red Hat  2016-07-15  304) }
0330f7aa Steven Rostedt (Red Hat  2016-07-15  305) 

:::::: The code at line 299 was first introduced by commit
:::::: 0330f7aa8ee63d0c435c0cb4e47ea06235ee4b7f tracing: Have hwlat trace migrate across tracing_cpumask CPUs

:::::: TO: Steven Rostedt (Red Hat) <rostedt@...dmis.org>
:::::: CC: Steven Rostedt <rostedt@...dmis.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (27719 bytes)