linux-kernel - Re: [PATCH] staging:rtl8188eu Remove unnecessary {} braces in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170921071536.visdfmkuvg2pv7sz@mwanda>
Date:   Thu, 21 Sep 2017 10:15:36 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Janani Sankara Babu <jananis37@...il.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        insafonov@...il.com, mihaela.muraru21@...il.com,
        goudapatilk@...il.com, linux-kernel@...r.kernel.org,
        palaviv@...il.com
Subject: Re: [PATCH] staging:rtl8188eu Remove unnecessary {} braces in

On Thu, Sep 21, 2017 at 12:18:04PM +0530, Janani Sankara Babu wrote:
> --- a/drivers/staging/rtl8188eu/hal/phy.c
> +++ b/drivers/staging/rtl8188eu/hal/phy.c
> @@ -728,9 +728,9 @@ static void patha_fill_iqk(struct adapter *adapt, bool iqkok, s32 result[][8],
>  	u32 oldval_0, x, tx0_a, reg;
>  	s32 y, tx0_c;
>  
> -	if (final_candidate == 0xFF) {
> +	if (final_candidate == 0xFF)
>  		return;
> -	} else if (iqkok) {
> +	else if (iqkok) {

No.  These ones stay.  Your change would introduce a new checkpatch.pl
warning if you ran it against the patched file.  The rule here is that
if one side of the if else has curly braces then both sides get them.

regards,
dan carpenter