linux-kernel - Re: [PATCH] staging:vme Fix use BIT macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEccXeetHpF=y8z+8OMD6vX16B-8=7cpSNxHFjxoyeO-s+NNwg@mail.gmail.com>
Date:   Thu, 21 Sep 2017 12:49:40 +0100
From:   Martyn Welch <martyn@...chs.me.uk>
To:     Janani Sankara Babu <jananis37@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Manohar Vanga <manohar.vanga@...il.com>, antonl1911@...il.com,
        Ricardo Silva <rjpdasilva@...il.com>,
        devel <devel@...verdev.osuosl.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging:vme Fix use BIT macro

On 21 September 2017 at 06:52, Janani Sankara Babu <jananis37@...il.com> wrote:
> This patch is created to solve the following warning shown by the checkpatch
> script Warning: Replace all occurences of (1<<x) by BIT(x)
>
> Signed-off-by: Janani Sankara Babu <jananis37@...il.com>
> ---
>  drivers/staging/vme/devices/vme_pio2.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/vme/devices/vme_pio2.h b/drivers/staging/vme/devices/vme_pio2.h
> index ac4a4ba..e9c3cf6 100644
> --- a/drivers/staging/vme/devices/vme_pio2.h
> +++ b/drivers/staging/vme/devices/vme_pio2.h
> @@ -179,7 +179,7 @@
>                                         PIO2_REGS_CTRL_WRD1 };
>
>  #define PIO2_CNTR_SC_DEV0              0
> -#define PIO2_CNTR_SC_DEV1              (1 << 6)
> +#define PIO2_CNTR_SC_DEV1              BIT(6)

Sorry, these changes just don't make sense given the defines below.

>  #define PIO2_CNTR_SC_DEV2              (2 << 6)
>  #define PIO2_CNTR_SC_RDBACK            (3 << 6)
>
> @@ -188,12 +188,12 @@
>                                         PIO2_CNTR_SC_DEV1, PIO2_CNTR_SC_DEV2 };
>
>  #define PIO2_CNTR_RW_LATCH             0
> -#define PIO2_CNTR_RW_LSB               (1 << 4)
> +#define PIO2_CNTR_RW_LSB               BIT(4)
>  #define PIO2_CNTR_RW_MSB               (2 << 4)
>  #define PIO2_CNTR_RW_BOTH              (3 << 4)
>
>  #define PIO2_CNTR_MODE0                        0
> -#define PIO2_CNTR_MODE1                        (1 << 1)
> +#define PIO2_CNTR_MODE1                        BIT(1)
>  #define PIO2_CNTR_MODE2                        (2 << 1)
>  #define PIO2_CNTR_MODE3                        (3 << 1)
>  #define PIO2_CNTR_MODE4                        (4 << 1)
> --
> 1.9.1
>