lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Sep 2017 14:17:21 +0200 From: Linus Walleij <linus.walleij@...aro.org> To: Zhiyong Tao <zhiyong.tao@...iatek.com> Cc: Matthias Brugger <matthias.bgg@...il.com>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, srv_heupstream@...iatek.com, Liguo Zhang <liguo.zhang@...iatek.com>, "Joe.C" <yingjoe.chen@...iatek.com>, hongkun.cao@...iatek.com, Biao Huang <biao.huang@...iatek.com>, YT Shen <yt.shen@...iatek.com>, Hongzhou Yang <hongzhou.yang@...iatek.com>, Erin Lo <erin.lo@...iatek.com>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@...ts.infradead.org>, "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org> Subject: Re: [PATCH 2/3] arm64: dts: mt2712: add pintcrl device node. On Thu, Sep 21, 2017 at 10:13 AM, Zhiyong Tao <zhiyong.tao@...iatek.com> wrote: > On Tue, 2017-08-22 at 15:04 +0200, Linus Walleij wrote: >> On Mon, Aug 14, 2017 at 5:23 PM, Matthias Brugger >> <matthias.bgg@...il.com> wrote: >> > On 07/31/2017 10:22 AM, Zhiyong Tao wrote: >> >> >> >> The commit includes two change: >> >> 1)add pintcrl device node for mt2712. >> >> 2)add pinfunc file for mt2712. >> >> >> >> Signed-off-by: Zhiyong Tao <zhiyong.tao@...iatek.com> >> >> --- >> >> arch/arm64/boot/dts/mediatek/mt2712-pinfunc.h | 1014 >> >> +++++++++++++++++++++++++ >> > >> > >> > Shouldn't this file be in include/dt-bindings/pinctrl? >> >> Only if it is also #included in the driver. >> >> Yours, >> Linus Walleij > > ==> > Thanks for your comment. > We see our some ICs(mt7623) which move the file to > "include/dt-bindings/pinctrl". other ICs(mt2701) which is put in > "arch/arm64/boot/dts/mediatek". > In mt2712, mt2712-pinfunc.h is only include by dts file. It won't be > included by driver. So which is better? "arch/arm64/boot/dts/mediatek/" > or "include/dt-bindings/pinctrl". If it is used in both arm and arm64 it is helpful to have it in include/dt-bindings so it can be shared between the two archs. If it is just (ever) for arm64 it can stay inside the arch tree. Yours, Linus Walleij
Powered by blists - more mailing lists