linux-kernel - Re: [PATCH 1/1] drivers:usb: use setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 21 Sep 2017 18:05:30 +0530
From:   Allen <allen.lkml@...il.com>
To:     Felipe Balbi <balbi@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 1/1] drivers:usb: use setup_timer

>
> subject should've been something like:
>
> usb: gadget: udc: omap: use setup_timer() helper
>
> Also, you should've Cced linux-usb@...r.kernel.org and
> linux-omap@...r.kernel.org
>
> On Thu, Sep 21, 2017 at 2:28 PM Allen Pais <allen.lkml@...il.com> wrote:
>>
>>     Use setup_timer function instead of initializing timer with the
>>     function and data fields.
>
>
> the spaces a the beginning of each line are pointless, please remove.
>
> Other than that, patch looks good. Please fix these details and resend.
>
  Sure.


-- 
       - Allen