linux-kernel - Re: [PATCH] nvme: make controller 'state' sysfs attribute pollable

Open Source and information security mailing list archives

Message-ID: <82f50ba2-a9c6-256f-5fd3-f515592c4fa7@huawei.com>
Date:   Thu, 21 Sep 2017 20:47:10 +0800
From:   Guan Junxiong <guanjunxiong@...wei.com>
To:     Christoph Hellwig <hch@....de>,
        Johannes Thumshirn <jthumshirn@...e.de>
CC:     Sagi Grimberg <sagi@...mberg.me>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
        Linux NVMe Mailinglist <linux-nvme@...ts.infradead.org>,
        Keith Busch <keith.busch@...el.com>,
        "Hannes Reinecke" <hare@...e.de>,
        "Shenhong (C)" <shenhong09@...wei.com>,
        niuhaoxin <niuhaoxin@...wei.com>
Subject: Re: [PATCH] nvme: make controller 'state' sysfs attribute pollable

On 2017/9/20 22:59, Christoph Hellwig wrote:
> On Wed, Sep 20, 2017 at 12:40:32PM +0200, Johannes Thumshirn wrote:
>> Notify sysfs about changes of a nvme controller so user-space can watch the
>> file via poll() or select() in order to react to a state change.
> 
> Userspace has no business polling for the state.
> 

Please consider this patch. At least upstream multipath-tools is using the sysfs state now:
[1] https://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=commitdiff;h=29c3b0446c4d919859f9e87b291563d483aab594
[2] https://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=commitdiff;h=d2561442cc0b444e8a728bac2c1466468816ee9d

> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
> 
> 

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives