linux-kernel - Re: [PATCH 6/6] lightnvm: include NVM Express driver if OCSSD is selected for build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170921134000.GA29269@dhcp-216.srv.tuxera.com>
Date:   Thu, 21 Sep 2017 16:40:00 +0300
From:   Rakesh Pandit <rakesh@...era.com>
To:     Matias Bjørling <mb@...htnvm.io>
CC:     <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Javier González <jg@...htnvm.io>
Subject: Re: [PATCH 6/6] lightnvm: include NVM Express driver if OCSSD is
 selected for build

On Thu, Sep 21, 2017 at 01:32:40PM +0200, Matias Bjørling wrote:
> On 09/21/2017 01:28 PM, Rakesh Pandit wrote:
> > Because NVM needs BLK_DEV_NVME, select it automatically if we mark NVM
> > in config file before building kernel.
> > 
> > Signed-off-by: Rakesh Pandit <rakesh@...era.com>
> > ---
> >   drivers/lightnvm/Kconfig | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig
> > index ead61a9..b3c00cb 100644
> > --- a/drivers/lightnvm/Kconfig
> > +++ b/drivers/lightnvm/Kconfig
> > @@ -5,6 +5,7 @@
> >   menuconfig NVM
> >   	bool "Open-Channel SSD target support"
> >   	depends on BLOCK && HAS_DMA
> > +	select BLK_DEV_NVME
> >   	help
> >   	  Say Y here to get to enable Open-channel SSDs.
> > 
> 
> Thanks Rakesh. I've picked it up for 4.15.

As discussed (IRC) I wasn't very careful first time and missed
appending PCI to depends as select doesn't visit dependencies
automatically.  Will post a version 2 soon.

Will only post version 2 of this very patch.

Doesn't make sense to push anything else from set.  Thank you in
advance,