linux-kernel - Re: [PATCH V2] lightnvm: include NVM Express driver if OCSSD is selected for build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5259c471-285d-c361-ac68-2907e69aba79@bjorling.me>
Date:   Thu, 21 Sep 2017 15:41:49 +0200
From:   Matias Bjørling <m@...rling.me>
To:     Rakesh Pandit <rakesh@...era.com>,
        Matias Bjørling <mb@...htnvm.io>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        Javier González <jg@...htnvm.io>
Subject: Re: [PATCH V2] lightnvm: include NVM Express driver if OCSSD is
 selected for build



On 09/21/2017 03:41 PM, Rakesh Pandit wrote:
> Because NVM needs BLK_DEV_NVME, select it automatically if we mark NVM
> in config file before building kernel.  Also append PCI to depends as
> select doesn't automatically add dependencies.
> 
> Signed-off-by: Rakesh Pandit <rakesh@...era.com>
> ---
> 
> V2: appends 'depends' with PCI
> 
>   drivers/lightnvm/Kconfig | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig
> index ead61a9..2a953ef 100644
> --- a/drivers/lightnvm/Kconfig
> +++ b/drivers/lightnvm/Kconfig
> @@ -4,7 +4,8 @@
>   
>   menuconfig NVM
>   	bool "Open-Channel SSD target support"
> -	depends on BLOCK && HAS_DMA
> +	depends on BLOCK && HAS_DMA && PCI
> +	select BLK_DEV_NVME
>   	help
>   	  Say Y here to get to enable Open-channel SSDs.
>   
> 

Thanks Rakesh.