linux-kernel - Re: [PATCH v2 1/2] include: linux: sysfs: Add __ATTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170921145442.0000160b@huawei.com>
Date:   Thu, 21 Sep 2017 14:54:42 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Himanshi Jain <himshijain.hj@...il.com>,
        Peter Meerwald <pmeerw@...erw.net>
CC:     Jonathan Cameron <jic23@...23.retrosnub.co.uk>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Greg KH <gregkh@...uxfoundation.org>,
        Jonathan Cameron <jic23@...nel.org>,
        driverdev <devel@...verdev.osuosl.org>,
        Daniel Baluta <daniel.baluta@...il.com>,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>,
        <linux-iio@...r.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        Nick Desaulniers <nick.desaulniers@...il.com>,
        outreachy-kernel <outreachy-kernel@...glegroups.com>,
        Hartmut Knaack <knaack.h@....de>
Subject: Re: [PATCH v2 1/2] include: linux: sysfs: Add __ATTR_NAMED macro

On Mon, 18 Sep 2017 16:19:07 +0530
Himanshi Jain <himshijain.hj@...il.com> wrote:

> On Thu, Sep 14, 2017 at 2:20 AM, Jonathan Cameron
> <jic23@...23.retrosnub.co.uk> wrote:
> >
> >
> > On 13 September 2017 12:23:31 GMT-07:00, Lars-Peter Clausen <lars@...afoo.de> wrote:  
> >>On 09/13/2017 08:58 PM, Greg KH wrote:  
> >>> On Wed, Sep 13, 2017 at 06:03:10PM +0100, Jonathan Cameron wrote:  
> >>>> On Wed, 13 Sep 2017 14:14:07 +0530
> >>>> Himanshi Jain <himshijain.hj@...il.com> wrote:
> >>>>  
> >>>>> Add __ATTR_NAMED macro similar to __ATTR but taking name as a
> >>>>> string instead of implicit conversion of argument to string using
> >>>>> the macro _stringify(_name).
> >>>>>
> >>>>> Signed-off-by: Himanshi Jain <himshijain.hj@...il.com>
> >>>>> ---
> >>>>>  include/linux/sysfs.h | 7 +++++++
> >>>>>  1 file changed, 7 insertions(+)
> >>>>>
> >>>>> diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
> >>>>> index aa02c32..20321cf 100644
> >>>>> --- a/include/linux/sysfs.h
> >>>>> +++ b/include/linux/sysfs.h
> >>>>> @@ -104,6 +104,13 @@ struct attribute_group {
> >>>>>    .store  = _store,                                               \
> >>>>>  }
> >>>>>
> >>>>> +#define __ATTR_NAMED(_name, _mode, _show, _store) {                       \  
> >>>>
> >>>> I'm not sure about the naming here.  The normal __ATTR macro is also
> >>>> 'named'.  Maybe something as awful as
> >>>>
> >>>> __ATTR_STRING_NAME ?
> >>>>
> >>>> Greg what do you think?  
> >>>
> >>> ick ick ick.
> >>>  
> >>>> This is all to allow us to have names with operators in them without
> >>>> checkpatch complaining about them... A worthwhile aim just to stop
> >>>> more people wasting time trying to 'fix' those cases by adding  
> >>spaces.  
> >>>
> >>> Yeah, but this really seems "heavy" for just a crazy sysfs name in a
> >>> macro.  Adding a whole new "core" define for that is a hard sell...
> >>>
> >>> I also want to get rid of the "generic" __ATTR type macros, and force
> >>> people to use the proper _RW and friends instead.  I don't want to  
> >>add  
> >>> another new one that people will start to use that I later have to
> >>> change...
> >>>
> >>> So no, I don't like this, how about just changing your macros  
> >>instead?  
> >>> No one else has this problem :)  
> >>
> >>Nobody else realized they have this problem yet. E.g. there are a few
> >>users
> >>of __ATTR in block/genhd.c that have the same issue and are likely to
> >>generate the same false positives from static checkers.  
> >
> > For IIO there is the option of moving these over to the core generated available callbacks, but
> > that won't work in every case and is a more major change.  I need to shift a few more drivers
> > over to the available callbacks and see how well it works out.  Might find time to do one in a
> >  gap between interesting talks this afternoon...  
> 
> Can I help you in this? It is about exploring options as far as I can
> make out, although can't really understand what options are those for
> now.

You are welcome to have a go.  However the relevant code isn't all that
well tested so I'd want to actually get enough of the setup to run to see
if it works (which is trickier).  I doubt anyone has ready access
to this hardware.

Anyhow, to see what I mean see : 

https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/tree/drivers/iio/dac/dpot-dac.c

In particular dpot_dac_read_avail() and 

static const struct iio_chan_spec dpot_dac_iio_channel = {
	.type = IIO_VOLTAGE,
	.info_mask_separate = BIT(IIO_CHAN_INFO_RAW)
			    | BIT(IIO_CHAN_INFO_SCALE),
	.info_mask_separate_available = BIT(IIO_CHAN_INFO_RAW),
	.output = 1,
	.indexed = 1,
};

What this does is allow the core to create *_available attributes
(sometimes this is required by in kernel consumers of the channels as they
need to know the range of the channel for example).

The intent ultimately is to move drivers over to this interface and hopefully
get rid of the majority of remaining hand specified attrs.

It's always been well down the todo list though as it is easy to get wrong
in a given driver and we need to get more emulation in place to allow
testing of the various drivers. There are a couple of ways of doing such
emulation (i2c devices can use the i2c-stub framework, or we can do full blown
qemu emulation) - both are interesting diversions.

Also I promised to write the ABI docs (see the original patches introducing
it for some docs) but haven't actually done so yet which makes it tricky
to tell people to start using this stuff even in new drivers!

Anyhow, whilst you are welcome to look at this it might be a high risk choice
for where to get started during the outreachy applications period.

Still nothing wrong with being brave, but perhaps discuss with Alison, Daniel
or Julia.

Thanks,

Jonathan

> 
> Or do you want me to put comments to not to fix this checkpatch
> warning as you suggested earlier?
> 
> >
> > If I am feeling really keen I might write this missing docs I promised a while back on that stuff. Jet lag dependant...
> >
> > Jonathan  
> >>
> >>--
> >>To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> >>the body of a message to majordomo@...r.kernel.org
> >>More majordomo info at  http://vger.kernel.org/majordomo-info.html  
> >
> > --
> > Sent from my Android device with K-9 Mail. Please excuse my brevity.  
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html