linux-kernel - Re: [PATCH] block: drop "sending ioctl to a partition" message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170921145300.GA1617@infradead.org>
Date:   Thu, 21 Sep 2017 07:53:00 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org, axboe@...nel.de,
        linux-block@...r.kernel.org
Subject: Re: [PATCH] block: drop "sending ioctl to a partition" message

This looks ok to me, but do we even need to keep the special
cases above?  Is there anything relying on the safe but not very
useful ioctls?

Condensing the thing down to:

int scsi_verify_blk_ioctl(struct block_device *bd, unsigned int cmd)
{
	if (bd && bd == bd->bd_contains)
		return 0;
	if (capable(CAP_SYS_RAWIO))
		return 0;
	return -ENOIOCTLCMD;
}

would certainly be nice.